Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Translator memory leak fixed #70

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Translator memory leak fixed #70

merged 1 commit into from
Nov 12, 2021

Conversation

tarampampam
Copy link
Collaborator

Description

Added

  • Listener FlushTranslatorCacheListener for memory leak fixing on Translator implementation

Related PR: laravel/octane#416

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #70 (305b552) into master (4f2eabc) will increase coverage by 0.18%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     74.90%   75.09%   +0.18%     
- Complexity      305      310       +5     
============================================
  Files            59       60       +1     
  Lines           797      807      +10     
============================================
+ Hits            597      606       +9     
- Misses          200      201       +1     
Impacted Files Coverage Δ
src/Defaults.php 100.00% <ø> (ø)
src/Listeners/FlushTranslatorCacheListener.php 90.00% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2eabc...305b552. Read the comment docs.

@tarampampam tarampampam marked this pull request as ready for review November 12, 2021 07:22
@tarampampam tarampampam merged commit 35a73dc into master Nov 12, 2021
@tarampampam tarampampam deleted the fix-translator-memleak branch November 12, 2021 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant