Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: update proto for the Temporal Message #64

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jul 12, 2024

Reason for This PR

  • Move all communication between RR and PHP (temporal) to the protobuf.

Description of Changes

  • Add fields previously used in JSON.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features

    • Introduced new targets in the build process for easier clean and regeneration of the build environment.
    • Expanded messaging protocol to include additional fields for enhanced workflow management.
  • Bug Fixes

    • Updated linting configuration to exclude specific paths, improving flexibility in development.
  • Chores

    • Updated various dependencies and the Go version for enhanced compatibility and performance.
  • Style

    • Adjusted code formatting settings to promote consistency in indentation across files.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 12, 2024
@rustatian rustatian requested a review from wolfy-j July 12, 2024 17:19
@rustatian rustatian self-assigned this Jul 12, 2024
Copy link

coderabbitai bot commented Jul 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes involve updates to several configuration files and protocol definitions, enhancing coding standards, build processes, and protocol structures. Key modifications include switching from tab to space indentation in the .editorconfig, adding new targets in the Makefile, and expanding the buf.yaml linting settings. Additionally, Go module dependencies were updated for better compatibility, and new fields were introduced in protocol buffers to improve message handling in workflows.

Changes

Files Change Summary
.editorconfig Changed indentation style from tab to space. Reformatted whitespace management settings for clarity.
Makefile Added clean target for removing the build directory and regenerate target for cleaning and regenerating the build environment.
buf.yaml Expanded the lint section to include an ignore list for excluding specific directories from linting checks.
go.mod Updated Go version to 1.22, toolchain to go1.22.5, and upgraded various dependencies for improved compatibility and performance.
proto/http/v1/http.proto Removed import of google/protobuf/any.proto and adjusted field indentation in Header and HeaderValue for better readability.
proto/temporal/v1/temporal.proto Introduced new fields in Message for enhanced workflow management, including task_queue, tick_time, replay, continue_as_new_suggested, and history_size.
third_party/api Updated subproject commit identifier, reflecting a revision in the underlying codebase.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant BuildSystem as BS
    participant CodeBase as CB
    participant Workspace as WS

    Developer->>BS: Initiate build process
    BS->>CB: Clean build artifacts
    BS-->>WS: Build from fresh state
    WS->>BS: Build completed
    BS-->>Developer: Notify build success
Loading

Poem

🐰 In the meadow where code does flow,
Whiskers twitch as new changes grow.
Spaces dance where tabs once lay,
Clean builds hop in a joyful way.
With each update, we cheer and play,
A bright new path, come what may! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review July 22, 2024 17:34
@rustatian rustatian merged commit bc182ac into master Jul 22, 2024
@rustatian rustatian deleted the feature/rr-2024.2-proto branch July 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant