-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version comparison inadequately compares strings #30
Comments
@lamansky I tried testing this using gitpkg.now.sh, and it doesn't fix the problem for me. How were you able to test this and confirm that it fixes the problem for you?
Editing to add: For some reason, VS Code's built-in eslint didn't pick up this change, but when executing |
Look what eslint-plugin-compat does: https://github.com/amilajack/eslint-plugin-compat/blob/main/src/providers/mdn-provider.ts |
There is also an issue where it does the sort for oldest versions in |
Released https://github.com/robatwilliams/es-compat/releases/tag/v3.0.0 with fix for this FYI @anomiex @dossy @lamansky @NoelDeMartin @NikolayFrantsev @ka2n |
Test file:
Browserslist:
safari >= 14, ios_saf >= 14
Expected output:
Actual output:
Notes:
The dataset used reports that the feature was added in version 9 of both browsers. While
14 > 9
is true,'14' > '9'
is false.The text was updated successfully, but these errors were encountered: