Added publish options for device and boundle nodes #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are some failing tests: |
|
I will update the tests. I am quite worried about code duplication. In XEP-0060 there is a method for publishing to a node with access model, but it is not quite usable here as it already adds the stanza to the queue and returns only the uuid. |
mimi89999
force-pushed
the
master
branch
2 times, most recently
from
c118b27
to
2388b17
Compare
|
I updated the test. Could you please review this pull request? |
chrisballinger
approved these changes
Feb 10, 2019
|
Thanks for the bump, looks good! I haven't tested it on my end yet but I think it's good to merge. If you want to make changes regarding my comments above I'll hold off on merging until I hear back from you, but it's not a dealbreaker either way. |
|
I changed the names to lowercase. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.