-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift Package Manager support #1177
Conversation
|
@karimhm This is awesome! What do you think about attempting a parallel |
@chrisballinger Swift tools version 5.3 are now supported via a parallel |
I posted a question at the swift forum regarding the issue. |
This seems to be a known bug |
It looks like SR-12912 won't be fixed in time for Swift 5.3, so perhaps we should move forward with this and just make sure to exclude any resource-related tests from SPM. We still have tests for those in the other Xcode projects that are run on CI. We should just make another ticket to track re-enabling those tests in SPM whenever it's fixed. I did have another concern about the approach of using symlinks for the |
This PR have unit tests on the SPM side excluding files that depend on module resources. Until SR-12912 gets resolved. |
|
SR-13560 seems to be the bug that is preventing tests from running properly. |
@chrisballinger All the tests are running now. Nothing excluded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimhm This is awesome stuff! Will be good to merge once the package manifest dependency URLs are fixed.
On a side note, Travis-CI has been crippled for open source projects and it would make sense to migrate to GitHub Actions at some point soon.
- rm -rf *.xcodeproj | ||
# Test the Swift PM project using `xcodebuild`. | ||
# The test is performed using `xcodebuild` rather than `swift test` due to this bug: | ||
# https://bugs.swift.org/browse/SR-13560 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the workaround! Hopefully Apple fixes this bug someday. Is there a Feedback Assistant report number that could be added to that ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not aware of any
Co-authored-by: Chris Ballinger <chrisballinger@gmail.com>
This can be done once this PR get merged |
Fixes #1176