Skip to content

Commit

Permalink
BLD: use libc++ for mac os builds. Min mac os version 10.9 (pandas-de…
Browse files Browse the repository at this point in the history
  • Loading branch information
robbuckley committed Nov 27, 2018
1 parent 0e7cf48 commit b8d1a38
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
def is_platform_windows():
return sys.platform == 'win32' or sys.platform == 'cygwin'


min_numpy_ver = '1.12.0'
setuptools_kwargs = {
'install_requires': [
Expand Down Expand Up @@ -426,14 +425,12 @@ def get_tag(self):
else:
endian_macro = [('__LITTLE_ENDIAN__', '1')]


if is_platform_windows():
extra_compile_args = []
else:
# args to ignore warnings
extra_compile_args = ['-Wno-unused-function']



# enable coverage by building cython files by setting the environment variable
# "PANDAS_CYTHON_COVERAGE" (with a Truthy value) or by running build_ext
# with `--with-cython-coverage`enabled
Expand Down Expand Up @@ -675,7 +672,8 @@ def srcpath(name=None, suffix='.pyx', subdir='src'):
include_dirs=include,
language=data.get('language', 'c'),
define_macros=data.get('macros', macros),
extra_compile_args=extra_compile_args)
extra_compile_args=['-stdlib=libc++', '-mmacosx-version-min=10.9'] + extra_compile_args,
extra_link_args=['-stdlib=libc++', '-mmacosx-version-min=10.9'])

extensions.append(obj)

Expand Down

0 comments on commit b8d1a38

Please sign in to comment.