Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuoteFix for Mac Mojave 10.14 #89

Open
ykhemka opened this issue Sep 23, 2018 · 44 comments
Open

QuoteFix for Mac Mojave 10.14 #89

ykhemka opened this issue Sep 23, 2018 · 44 comments

Comments

@ykhemka
Copy link

ykhemka commented Sep 23, 2018

Hello,

Please advise when would the updates be available for macOS Mojave 10.14.
@robertklep
Copy link
Owner

robertklep commented Sep 23, 2018 •
edited
Loading

To be honest: no idea.

Due to time constraints I haven't worked on Mojave-support at all, so once Mojave is released I will try and get it work ASAP. However, I've heard from other Mail plugin developers that it might not be trivial to get it working due to additional security measures imposed by Mojave.

v2.10.0-alpha.1 should work on Mojave.

@ykhemka
Copy link
Author

ykhemka commented Sep 23, 2018 via email

@alexlevitskycom
Copy link

It is very sad. The plugin is just amazing. It is unfortunate that QuoteFix does not work for Mojave. I do not understand, why Apple is blocking the road to such wonderful plugins for Apple Mail. I know a dozen people who enjoyed using it and now can not after the update to Mojave.

Maybe you have any ideas about how to make bottom posting possible through Apple Automator or any other Apps?

@robertklep
Copy link
Owner

A part of what QuoteFix does, namely reformatting/cleaning up the message, could probably be implemented by means of a Mail rule that would match every new mail and run an (Apple)script on it, although I've never really tried that myself.

As for cursor placement (below the original message), that's really something that has to be done from Mail (or a plugin) itself.

@alexlevitskycom
Copy link

Thank you for your comment!

Maybe I'm wrong, but I have a feeling that the implementation of bottom posting using Apple Mail rules or Apple Automator scripting (which I have no idea how to implement), under quoted (original) message — is the only logical continuation of the tremendous QuoteFix & best decision in situation while QuoteFix doesn't work at Mojave (I hope that temporarily and the task will be solved with time).

@jklundell
Copy link

It's worth noting that a big part of QF's charm is that it piggybacks on the existing ⌘R and ⇧⌘R, along with their toolbar equivalents. I can imagine a script of some sort that, once a top-posted reply was invoked, would select it, edit it, and replace it. And such a script might be better than doing it manually, but not nearly so compelling.

@jklundell
Copy link

This seems like a promising sign: https://gpgtools.tenderapp.com/kb/gpgmail-faq/enable-gpg-mail-on-macos-1014-mojave

@archodessa
Copy link

If anybody tried? QuoteFix works at Mojave now?

@robertklep
Copy link
Owner

If only it was that easy 😞 It's not just allowing the plugin to load or adding the correct UUID, the plugin crashes almost immediately because of changes made to Mail.

@jklundell
Copy link

Yeah. I'm not suggesting that it's as simple a matter as enabling QuoteFix, just that Mail plugins are at least not ruled out in Mojave.

@dnblankedelman
Copy link

I know this is not even in the same league as my much mourned QuoteFix, but perhaps as a terrible stopgap: https://daringfireball.net/2007/07/non_top_posting_scripts .

I have not been able to bring myself to try it, but wanted to report on something I found while looking to see if anyone else has done anything even remotely as amazing as Robert's work on his plugin.

@mgguinne
Copy link

mgguinne commented Oct 9, 2018

@dnblankedelman I have been thinking there might be a way to create an AppleScript to do this instead of QF (will not be anywhere as good though), the script you gave is a good start but I wonder how to copy the email name and insert it? Maybe someone has already done this and I just should search myself...

@jimklo
Copy link

jimklo commented Oct 22, 2018

It seems like Apple now must have somewhat honest to goodness support for Plug-ins in Mojave, given there is now a "Manage Plug-ins..." Button and interface on the General Preferences tab of Mojave Mail. MailHub recently added functional support, so I'm hoping there is at least a better path forward for the Mail plug-in society.

@defrilitus
Copy link

Reply With Header seems like it could be a stop-gap solution until QuoteFix can be updated. Certainly not as good, but better than nothing.

@glgray
Copy link

glgray commented Nov 14, 2018

Which setting in RWH mimics QuoteFix's top-quoting behavior? I am not seeing it.

@defrilitus
Copy link

I used QuoteFix only for the extensive reply-header options. Sorry.

@gravesit
Copy link

gravesit commented Nov 15, 2018 •
edited
Loading

I was able to get QuoteFix to work in Mojave by adding the following to Info.plist within the QuoteFix.mailbundle by right clicking on the bundle and "Show Package Contents":

@@ -104,6 +104,11 @@
        <array>
                <string>C86CD990-4660-4E36-8CDA-7454DEB2E199</string>
        </array>
+       <key>Supported10.14PluginCompatibilityUUIDs</key>
+       <array>
+               <string>A4343FAF-AE18-40D0-8A16-DFAE481AF9C1</string>
+       </array>
        <key>SupportedPluginCompatibilityUUIDs</key>
        <array>
                <string>225E0A48-2CDB-44A6-8D99-A9BB8AF6BA04</string>
@@ -155,6 +160,7 @@
                <string>DAF41AB7-F9AD-4273-9934-C81C74705B69</string>
                <string>1550C683-EA48-4036-B7CE-FB6F5D13EE02</string>
                <string>71562B89-0D90-4588-8E94-A75B701D6443</string>
+               <string>C86CD990-4660-4E36-8CDA-7454DEB2E199</string>
        </array>
 </dict>

Modified the install script from ReplyWithHeader to work for installing QuoteFix by changing "ReplyWithHeader" to "QuoteFix" and running the script from the QuoteFix-v2.9.0 directory. Then all you have to do is enable in mail preferences -> General -> Manage Plug-ins... and restart mail.

@defrilitus
Copy link

Works perfectly! Thank you ever so much :-)

@dnblankedelman
Copy link

@gravesit That sounds very promising.

Back in Oct, @robertklep said "the plugin crashes almost immediately because of changes made to Mail." Are you not seeing that behavior any more?

@robertklep
Copy link
Owner

robertklep commented Nov 15, 2018 •
edited
Loading

Yeah, I'm interested too! 😄

EDIT: okay, I can confirm that the method describe above works! I'll ask the developer of ReplyWithHeader if I can use their script for QuoteFix, and will push a new release shortly.

@gravesit
Copy link

@dnblankedelman Been 24 hours with mail open and zero issues using the install method outlined.

@defrilitus
Copy link

I installed the fix manually, but it's working fine all the same. Great news for lovers of this plug-in!

@sojuzpl
Copy link

sojuzpl commented Nov 15, 2018

it really works! Thx @gravesit

@ykhemka
Copy link
Author

ykhemka commented Nov 16, 2018

Hello,

I am unable to proceed, can you please send the info.plist file.

@defrilitus
Copy link

defrilitus commented Nov 16, 2018 •
edited
Loading

Hello,

I am unable to proceed, can you please send the info.plist file.

Here is the whole bundle: QuoteFix 2.9 by @robertklep, including info.plist modifications by @gravesit. Not my work, of course; many thanks to both of them 👍

QuoteFix.mailbundle.zip

@ykhemka
Copy link
Author

ykhemka commented Nov 16, 2018 via email

@robertklep
Copy link
Owner

robertklep commented Nov 16, 2018 •
edited
Loading

I just released v2.10.0-alpha.1.

I haven't heard back from the developer of ReplyWithHeader if it's okay to include their install scripts, so I went ahead and included them for the time being.

Please let me know (thumb-up this comment) if the installation process works okay, so I can do a proper stable release.

@alexlevitskycom
Copy link

alexlevitskycom commented Nov 16, 2018 via email

@dnblankedelman
Copy link

@robertklep related aside (since I tried this before your release, hence not being a direct thumbs up): I did a manual update of the plugin using the info the ReplyWithHeader shell script (ultimately just a cp command plus permission fixes). Before I could do that, I had to grant Terminal Full Disk Access. I do not know whether or not shell scripts individually need to be given that permission, but I thought I should bring it up just in case it is a thing.

The manual update to last stable with the new plist and the previous code has been working peachy for me.

@robertklep
Copy link
Owner

@dnblankedelman yeah, you need to grant Terminal those rights :) In my release, it's documented in the accompanying README file on how to do that.

@dnblankedelman
Copy link

Ah, you rock (as usual).

@jklundell
Copy link

a1 worked fine as upgrade, except the last message 'Follow the "Step 3" from "Install-Instructions-Mojave-OS-and-Above.txt' needs revision.

@robertklep
Copy link
Owner

@jklundell oops, cut&pasted a bit too much ;) thanks!

@alexlevitskycom
Copy link

Apple Mail restarts ofter after clicking on reply, with the last update for Mojave.
screen shot 2018-12-01 at 00 23 20

And shows this message.
screen shot 2018-12-01 at 00 17 32

Any ideas how to avoid?

@robertklep
Copy link
Owner

@alexlevitskycom I assume that the plugin is causing Mail to crash. As for the reason, I have no idea without more information. You could fire up the Console app to try and find out if any reason is being logged what is causing the crash.

@mgguinne
Copy link

mgguinne commented Dec 3, 2018 •
edited
Loading

@alexlevitskycom I assume that the plugin is causing Mail to crash. As for the reason, I have no idea without more information. You could fire up the Console app to try and find out if any reason is being logged what is causing the crash.

I have the same issue, sorry this was happening when you first released it and just did not worry (thought it was just me), though now someone else is having the same issue it would be nice to know how to fix.

However, I just went to send you some logs, I enabled it got the error message (forgot to get the crash log as mail reopened). I then went back in and enabled it again in mail, let it restart and then boom it works. Very strange.

@archodessa
Copy link

After mac resetting, the plugin is unchecked at Mail plugin manager, usually.

@ykhemka
Copy link
Author

ykhemka commented Dec 3, 2018 via email

@defrilitus
Copy link

@ykhemka Could you please explain what you mean by "grant full access through privacy"? If you mean QuoteFix, I see no way to do it (Security & Privacy settings in System Preferences are for apps only).
I am having the same problem as @archodessa: every time I close and restart Mail (or my Mac, I'm not sure which), the plugin is unchecked in Mail Plugin Manager.

@ykhemka
Copy link
Author

ykhemka commented Dec 11, 2018 via email

@robertklep
Copy link
Owner

@defrilitus I think they meant "grant full disk access to the Mail app".

Like I said, I had the issue of QF being disabled after a reboot, but it doesn't get disabled when restarting Mail (I did set the Full Disk Access after the reboot, and haven't rebooted since, so can't comment if that is the reason why it's working for me between restarts of Mail).

@defrilitus
Copy link

@robertklep QF is indeed being disabled after a reboot, but not after restarting the Mail app. For the moment, it seems that granting the Mail app FDA fixes the bug. I'll do some further testing this week to check if FDA is "the" solution here.

@defrilitus
Copy link

@robertklep After a couple of days of testing, it seems that granting the Mail app full disk access does prevent QuoteFix from being automatically disabled. The only exception, of course, is when macOS (and thus the Mail app) is updated to a new version, but that is to be expected. Maybe a note suggesting enabling FDA for the Mail app should be in the installation instructions?

robertklep added a commit that referenced this issue Dec 16, 2018
@robertklep
See #89
0da5579
@mgguinne
Copy link

mgguinne commented Jan 9, 2019

I got this to work, I was having issues with the preferences not coming up once added (mail hanging). Once I gave Mail app full disk access, no further issues.

Thanks for this @robertklep , it's really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests