fix: handle non-existing settings folder

robianmcd · Jun 16, 2023 · e379de0 · e379de0
1 parent 2b67137
commit e379de0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/MidiShapeShifter/MidiShapeShifter/Mss/MssConstants.cs b/MidiShapeShifter/MidiShapeShifter/Mss/MssConstants.cs
@@ -3,5 +3,6 @@
     public static class MssConstants
     {
         public const string APP_NAME = "MIDI Shape Shifter";
+        public const string APP_FOLDER_NAME = "MidiShapeShifter";
     }
 }
diff --git a/MidiShapeShifter/MidiShapeShifter/Mss/MssFileSystemLocations.cs b/MidiShapeShifter/MidiShapeShifter/Mss/MssFileSystemLocations.cs
@@ -12,15 +12,21 @@ public static string SettingsFolder
             get
             {
                 RegistryKey mssLocalMachineRegKey = CreateMssCurrentUserRegKey();
-                var settingsFolder = mssLocalMachineRegKey.GetValue("SettingsFolder");
+                var settingsFolderObject = mssLocalMachineRegKey.GetValue("SettingsFolder");
 
                 // if doesn't exist, create it
-                if (settingsFolder == null)
+                string settingsFolder = "";
+                if (settingsFolderObject == null)
                 {
-                    mssLocalMachineRegKey.SetValue("SettingsFolder", MssConstants.DEFAULT_SETTINGS_FOLDER);
-                    settingsFolder = mssLocalMachineRegKey.GetValue("SettingsFolder");
+                    // set it to the current user's Documents/MidiShapeShifter folder
+                    string current_user_documents_folder = System.Environment.GetFolderPath(System.Environment.SpecialFolder.MyDocuments);
+                    Debug.Assert(current_user_documents_folder != "");
+                    string default_settings_folder = current_user_documents_folder + @"\" + MssConstants.APP_FOLDER_NAME + @"\";
+
+                    mssLocalMachineRegKey.SetValue("SettingsFolder", default_settings_folder);
+                    settingsFolder = default_settings_folder;
                 }
-                Debug.Assert(settingsFolder != null);
+                Debug.Assert(settingsFolder != "");
 
                 mssLocalMachineRegKey.Close();