Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to have Remember Me chedked by default #190

Closed
wants to merge 2 commits into from

Conversation

RobLoach
Copy link

@RobLoach RobLoach commented Feb 6, 2024

This introduces a --template-remember-checked option that allows the "Remember me" checkbox to be toggled on by default.

README.md Outdated Show resolved Hide resolved
@robinmoisson
Copy link
Owner

Thanks for the suggestion @RobLoach!

A couple of thoughts that make me hesitate:

  • since clearing the remember-me is non-trivial (you don't have a logout button and need to know to append #staticrypt_logout to the url, which as a user you won't know about) I think it's somewhat risky to have the Remember-me checked by default, since you can end up staying "logged-in" and having no idea how to logout
  • it's a bit late since we already have 20-ish CLI flags but if possible I'd want to keep the list relatively tight to make the tool simpler to use, and make sure to have clear reasons to add new ones

Could you share more about what use cases you have in mind for that option?

@RobLoach
Copy link
Author

Largest motivation for the option is so that people unfamiliar with the tool don't constantly get asked to re-input the password if they miss seeing the checkbox.

Happy to keep the amount of options to a minimum. In order to save having to add another option, we could support using a negative number in the remember me expiration time.

-5 would indicate remember me for 5 days, with a default for the checkbox being toggled.

@robinmoisson
Copy link
Owner

robinmoisson commented Feb 22, 2024

Thanks for detailing the use case @RobLoach.

So where I stand so far is that it's a potentially dangerous option for people who didn't think it through, because it can lead to having the file auto-decrypted unintentionally and not knowing how to turn it off and that feels like a pretty big deal. I'd think that if the user doesn't see the checkbox the first few times, either they don't mind entering the password each time or they'll be frustrated enough that they'll read the password prompt enough to find the checkbox - it's a pretty standard pattern after all.

I feel like the drawbacks outweigh the benefits so I don't think it should be included in the CLI options. And if someone thought it through and really wants it they can always edit the password_template to make the checkbox checked by default.

Thanks for the PR and the suggestion nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants