new upload parameter for overwriting annotations #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolomonLake
requested changes
Jan 9, 2024
roboflow/core/project.py
Outdated
| @@ -469,6 +469,7 @@ def single_upload( | |||
| image_path=None, | |||
| annotation_path=None, | |||
| annotation_labelmap=None, | |||
| annotation_overwrite=False, | |||
There was a problem hiding this comment.
Can you move to the end of the parameters list so as to keep backwards compatible with previous versions?
There was a problem hiding this comment.
@SolomonLake I accidentally closed the issue before actually merging. I think you need to approve a second time. Sorry for the inconvenience.
There was a problem hiding this comment.
Failed to build due to styling -- running make style in the root directory should fix the issue.
There was a problem hiding this comment.
Hope the styling checks out now.
There was a problem hiding this comment.
Looks good, i'll merge the PR now!
SolomonLake
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new parameter for the single_upload method to enable overwriting annotations via the API. This has been requested by multiple other users. The option was available via the REST API, but not the python SDK.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested upload of image with annotations then deleted part of the annotations manually, and re-uploaded only the annotations.
Any specific deployment considerations
One of the unittests was already broken on the main branch (
test_download_returns_datasetintests.test_version. I did not touch this.Docs