Helmfile should pass --args to "helm repo add"

[almed4]

Summary

When adding a repo, default args are not passed to the command helm repo add.

Expected Behavior

With helmfile.yaml configured with the following:

helmDefaults:
  args:
    - "--pass-credentials"

helm repo add should be called with --pass-credentials

Expected

exec: helm repo add repo https://raw.githubusercontent.com/owner/repo/ref/dir --force-update --username *** --password *** --pass-credentials

Actual Behavior

With helmfile.yaml configured with the following:

helmDefaults:
  args:
    - "--pass-credentials"

helm repo add is called without --pass-credentials

Actual

exec: helm repo add repo https://raw.githubusercontent.com/owner/repo/ref/dir --force-update --username *** --password ***

Feature Request/Bug

helmfile should pass default helm arguments to helm repo add or allow arguments to be included in a repositories object.

[mumoshu]

@almed4 Hey! Helmfile doesn't have a map of which helm command supports which args so it currently passes it to a "primary" helm command that corresponds to the helmfile command you're running. For helmfile apply it is helm upgrade --install and for helmfile diff it's helm diff.

That said, adding passCredentials field to repositories entry would be better.

Would you mind submitting a PR for that?

[almed4]

Yes, I would love to! Thanks so much for your quick response. Please bare with me since I am not familiar with Go, but I'm super excited to contribute. This is my first open-source contribution lol.

Will open PR with personal account @ameddin73

[ameddin73]

@mumoshu please review

[mumoshu]

Let me note that I learned this flag was added I learned pass-credentials has been added in helm 3.6.1 https://github.com/helm/helm/releases/tag/v3.6.1