Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Helm chart by URL #675

Closed
bastianeicher opened this issue Jun 11, 2019 · 5 comments · Fixed by #695
Closed

Reference Helm chart by URL #675

bastianeicher opened this issue Jun 11, 2019 · 5 comments · Fixed by #695
Labels

Comments

@bastianeicher
Copy link
Contributor

With Helm I can reference a chart via an absolute URL instead of using the repository/chart syntax. For example:

helm install https://github.com/arangodb/kube-arangodb/releases/download/0.3.11/kube-arangodb-crd.tgz

However helmfile seems to interpret the URL as a local path if I write this in my helmfile.yaml:

releases:
  - name: arangodb-crd
    chart: https://github.com/arangodb/kube-arangodb/releases/download/0.3.11/kube-arangodb-crd.tgz

Would it be possible to support this helmfile too?

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 12, 2019

@bastianeicher Thanks for the request! Yeah probably. It should work if the URL can be accepted as the first arg to helm fetch, helm upgrade, helm diff, etc. that helmfile calls.

Helmfile has not expected URLs in chart. So maybe it's matter of relaxing the validation if it fails due to that?

@robinro
Copy link

robinro commented Jun 14, 2019

This used to work. The example helmfile given by @bastianeicher used to work with helmfile. Based on my quick bisect running helmfile diff using that helmfile the first broken version is c9a43ad

@mumoshu If you are interested I could try to work on a fix. Can you give me some hints?

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 16, 2019

@robinro Good catch! Seems like I've unintentionally broken this along with #687 in the commit you pointed.

Not sure which part of my commit went wrong I'll take a look and report back once I find something.

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 16, 2019

Okay so it seems to be caused by helmfile calling helm dep build on the remote chart uri. Looking deeper now..

$ helm dependency build https://github.com/arangodb/kube-arangodb/releases/download/0.3.11/kube-arangodb-crd.tgz
Error: could not find https://github.com/arangodb/kube-arangodb/releases/download/0.3.11/kube-arangodb-crd.tgz: stat https://github.com/arangodb/kube-arangodb/releases/download/0.3.11/kube-arangodb-crd.tgz: no such file or directory

mumoshu added a commit that referenced this issue Jun 16, 2019
We unintentionally broke this since #593.

Fixes #675
Fixes #687
mumoshu added a commit that referenced this issue Jun 16, 2019
We unintentionally broke this since #593.

Fixes #675
Fixes #687
@robinro
Copy link

robinro commented Jun 16, 2019

Thanks @mumoshu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants