Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to load a remote environment values file #1296

Merged
merged 7 commits into from
Jun 11, 2020

Conversation

kevinjqiu
Copy link
Contributor

This PR enables the user to specify a remote path for an environment values file, e.g.,

environments:
  cluster-azure-us-west:
    values:
      - git::https://git.company.org/helmfiles/global/azure.yaml?ref=master
      - git::https://git.company.org/helmfiles/global/us-west.yaml?ref=master
  cluster-gcp-europe-west:
    values:
      - git::https://git.company.org/helmfiles/global/gcp.yaml?ref=master
      - git::https://git.company.org/helmfiles/global/europe-west.yaml?ref=master

releases:
  - ...

This is particularly useful when you co-locate helmfiles within your project repo but want to reuse the definitions in a global repo.

Please let me know what y'all think. Thanks.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinjqiu Hey! Thanks a lot for your contribution. LGTM.

Just wanted to ask if you have any idea how we could add some tests for this. Mocking out Remote for unit testing, create a real github repo for E2E testing, etc.?

@mumoshu mumoshu merged commit 0f86cc9 into roboll:master Jun 11, 2020
@kevinjqiu kevinjqiu deleted the remote-values-file branch June 11, 2020 01:27
@kevinjqiu
Copy link
Contributor Author

@kevinjqiu Hey! Thanks a lot for your contribution. LGTM.

Just wanted to ask if you have any idea how we could add some tests for this. Mocking out Remote for unit testing, create a real github repo for E2E testing, etc.?

Thanks @mumoshu

wrt testing, what you said makes sense. E2E testing should be emphasized IMO.

@lodotek
Copy link

lodotek commented Jul 7, 2022

has this been tested against private gitlab repos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants