Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching helmfiles as .tar.gz #1844

Closed
wants to merge 1 commit into from

Conversation

mseiwald
Copy link

@mseiwald mseiwald commented May 12, 2021

Fixes #1842

Example:

helmfiles:
  - path: https://host/path@helmfile.yaml.tar.gz

@mseiwald
Copy link
Author

@mumoshu First super simplistic implementation but it actually works. Feedback appreciated.

@mumoshu
Copy link
Collaborator

mumoshu commented May 16, 2021

@mseiwald Hey! Thanks for your effort.

I gave it a shot and to me this doesn't work:

helmfiles:
  - path: https://github.com/helmfile/testdata/releases/download/test@helmfile-test.tar.gz

But this one works:

helmfiles:
  - path: https://github.com/helmfile/testdata/releases/download/test/helmfile-test.tar.gz@

Probably you expect the tarball to contain a single directory named $BASE where your tarball is named $BASE.tar.gz, right? Mine contains helmfile.yaml at the root level of the archive.

I'd say the latter form is better in respect to the meaning of @ in helmfile, whose right part refers to a path in the downloaded directory.

That said, can you verify that it works with `helmfiles:

@mseiwald
Copy link
Author

@mumoshu Actually it works like this:

helmfile.yaml.tar.gz needs to contain a helmfile.yaml at the root level of the archive. (everything before .tar.gz is supposed to be the path of the "entry level" helmfile.

So in your first example you probably just need to rename the tar file.

Would that work for you?

@mseiwald
Copy link
Author

I just realized that your suggestion already works with the latest unmodified helmfile. 🤦

helmfiles:
  - path: https://host/path/to/helmfile.yaml.tar.gz@helmfile.yaml

I'll just close this PR then since I agree that this is also the clearest syntax. Thanks anyway. :)

@mseiwald mseiwald closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote helmfiles via http (go-getter)
2 participants