Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wait Until Location Is keyword #1297

Closed
aaltat opened this issue Jan 19, 2019 · 3 comments
Closed

Add Wait Until Location Is keyword #1297

aaltat opened this issue Jan 19, 2019 · 3 comments
Labels
acknowledge To be acknowledged in release notes alpha 1 enhancement good first issue Good for newcomers help wanted Extra help appreciated priority: medium
Milestone
v4.0.0

Comments

@aaltat
Copy link
Contributor

aaltat commented Jan 19, 2019

In #1108 added Wait Until Location Contains keyword. For consistency reason add also Wait Until Location Is keyword.
@aaltat aaltat added enhancement help wanted Extra help appreciated priority: medium good first issue Good for newcomers labels Jan 19, 2019
@aaltat aaltat added this to the v3.4.0 milestone Jan 19, 2019
@Caos-Maker89
Copy link
Contributor

just 10 minutes and I've finish :)

@Caos-Maker89 Caos-Maker89 mentioned this issue Jan 20, 2019
Closed
@Caos-Maker89
Copy link
Contributor

done, pull request is ready.

@aaltat aaltat added the acknowledge To be acknowledged in release notes label Jan 21, 2019
Caos-Maker89 pushed a commit to Caos-Maker89/SeleniumLibrary that referenced this issue Jan 21, 2019
robotframework#1297: new wait until location is keyword and atest
5588670
@Caos-Maker89 Caos-Maker89 mentioned this issue Jan 21, 2019
Merged
aaltat pushed a commit that referenced this issue Jan 21, 2019
@aaltat
#1297: new wait until location is keyword and atest
ab73085
@aaltat
Copy link
Contributor Author

aaltat commented Jan 21, 2019

Done with #1300

@aaltat aaltat closed this as completed Jan 21, 2019
@aaltat aaltat added the alpha 1 label Apr 18, 2019
@aaltat aaltat mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledge To be acknowledged in release notes alpha 1 enhancement good first issue Good for newcomers help wanted Extra help appreciated priority: medium
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
2 participants
@aaltat @Caos-Maker89