Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If output dir contains multiple { and } characters pairs, then opening browser with Firefox will fail. #1452

Closed
aaltat opened this issue Sep 17, 2019 · 0 comments · Fixed by #1468

Comments

@aaltat
Copy link
Contributor

aaltat commented Sep 17, 2019

If robot is run with command: robot -d {foo}_dir path/to/suite then Open Browser keyword will fail with Firefox on: KeyError: 'foo'. This is because Python format is used. Same problem also applies to Capture Page Screenshot.

Build a wrapper that handle formatting for Python 2 and Python 3. For Python 3: https://docs.python.org/3/library/stdtypes.html#str.format_map is nice. For Python 2 build a something like: https://stackoverflow.com/questions/17215400/python-format-string-unused-named-arguments

@aaltat aaltat added this to the V4.1.0 milestone Sep 17, 2019
@aaltat aaltat self-assigned this Sep 17, 2019
@aaltat aaltat changed the title It output dir contains { and } characters, then opening browser with Firefox will fail. If output dir contains { and } characters, then opening browser with Firefox will fail. Sep 23, 2019
aaltat added a commit that referenced this issue Sep 30, 2019
/path/{to}/file-{index}.log types of paths causes problems for Python format method. This is now fixed. 

Fixes  #1452
@aaltat aaltat changed the title If output dir contains { and } characters, then opening browser with Firefox will fail. If output dir contains multiple { and } characters pairs, then opening browser with Firefox will fail. Oct 1, 2019
@aaltat aaltat added the rc 1 label Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant