Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users should not be required to define a URL to Open Browser keyword. #1464

Closed
JonKoser opened this issue Sep 28, 2019 · 0 comments
Closed

Users should not be required to define a URL to Open Browser keyword. #1464

JonKoser opened this issue Sep 28, 2019 · 0 comments
Labels
acknowledge To be acknowledged in release notes enhancement priority: medium rc 1
Milestone
v4.1.0

Comments

@JonKoser
Copy link
Contributor

JonKoser commented Sep 28, 2019 •
edited
Loading

Currently, the Open Browser keyword requires users to pass a URL to navigate to upon opening the browser. However, in some cases that may not be desired and the user might simply want to open the browser. (as in the case of Chromium-based applications).

Users should not need to specify this argument and the URL should be None by default. If None or not specified, navigation shouldn't occur.

I don't have a PR for this yet but can have one as soon as I can get back to my computer. Also sorry about the title "pay" - autocorrect :)
@aaltat aaltat changed the title Users should not be required to pay a URL to Open Browser Users should not be required to define a URL to Open Browser keyword. Sep 29, 2019
@JonKoser JonKoser mentioned this issue Sep 30, 2019
Merged
@aaltat aaltat added the acknowledge To be acknowledged in release notes label Oct 1, 2019
@aaltat aaltat closed this as completed in 9dd7017 Oct 4, 2019
@aaltat aaltat added this to the V4.1.0 milestone Oct 8, 2019
@aaltat aaltat mentioned this issue Oct 10, 2019
Closed
@aaltat aaltat added the rc 1 label Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledge To be acknowledged in release notes enhancement priority: medium rc 1
Projects
None yet
Milestone
v4.1.0
Development

No branches or pull requests
2 participants
@aaltat @JonKoser