Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional URL in Open Browser #1470

Merged
merged 9 commits into from
Oct 4, 2019
Merged

Optional URL in Open Browser #1470

merged 9 commits into from
Oct 4, 2019

Conversation

JonKoser
Copy link
Contributor

Makes the URL in the Open Browser keyword optional. This means that you can just open a browser without immediately navigating to a URL. In response to issue #1464

aaltat
aaltat requested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good but needs test.

@JonKoser
Copy link
Contributor Author

Added a unit test where Open Browser is called without any arguments. No .robot acceptance tests added since I noticed that there were no other default value Open Browser tests in that suite.

@JonKoser JonKoser marked this pull request as ready for review September 30, 2019 19:13
aaltat
aaltat requested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test is a good start, but it needs to look deeper what gets called from the WebDriver.

utest/test/keywords/test_keyword_arguments_browsermanagement.py Show resolved Hide resolved
utest/test/keywords/test_keyword_arguments_browsermanagement.py Outdated Show resolved Hide resolved
@JonKoser
Copy link
Contributor Author

New unit test to check that get() is never called when no URL is specified

@aaltat
Copy link
Contributor

aaltat commented Oct 1, 2019

Looking pretty good from a mobile screen. I need to take another look from a bigger screen to make sure that I did not miss anything.

@aaltat
Copy link
Contributor

aaltat commented Oct 4, 2019 •
edited
Loading

This is ready to be merged. Thank you for the contribution.

I will take a look your other PR during the weekend.

@aaltat aaltat closed this Oct 4, 2019
@aaltat aaltat reopened this Oct 4, 2019
@aaltat
Copy link
Contributor

aaltat commented Oct 4, 2019

Darn that close button is too near Comment button.

@JonKoser
Copy link
Contributor Author

JonKoser commented Oct 4, 2019

Thanks for helping out with this!

@aaltat aaltat merged commit 9dd7017 into robotframework:master Oct 4, 2019
@JonKoser JonKoser deleted the feature/optional_url branch October 8, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaltat aaltat aaltat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonKoser @aaltat