Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SeleniumLibrary profile for Firefox #883

Closed
aaltat opened this issue Sep 2, 2017 · 1 comment
Closed

Remove SeleniumLibrary profile for Firefox #883

aaltat opened this issue Sep 2, 2017 · 1 comment
Assignees
@aaltat
Labels
backwards incompatible beta 3 enhancement priority: medium
Milestone
v3.0.0

Comments

@aaltat
Copy link
Contributor

aaltat commented Sep 2, 2017

The SeleniumLibrary has long contained a custom Firefox profile, but the profile is based on very old version of Firefox. Also the profile was last updated in 2011. I would be better to use the default profile provided by the Selenium FirefoxProfile.

The change is possibly backwards incompatible and therefore added bwic label.
@aaltat aaltat added this to the v3.0.0 milestone Sep 2, 2017
@aaltat aaltat self-assigned this Sep 2, 2017
@aaltat
Copy link
Contributor Author

aaltat commented Sep 2, 2017

It seems that geckodriver.log is diverted by default to execution path, which is not nice. It would be better to divert the geckodriver.log to ${OUTPUT_DIR} which is more logical place.

@aaltat aaltat added rc 1 and removed beta 2 labels Sep 2, 2017
aaltat added a commit to aaltat/SeleniumLibrary that referenced this issue Sep 2, 2017
@aaltat
Removes SeleniumLibrary Firefox profile
6afe8db 
The SeleniumLibrary default Firefox profile is now removed. When
Firefox created and if Firefox profile is not defined, then the
default Selenium FirefoxProfile is used.

Fixes robotframework#883
@aaltat aaltat mentioned this issue Sep 2, 2017
Merged
aaltat added a commit to aaltat/SeleniumLibrary that referenced this issue Sep 4, 2017
@aaltat
Removes SeleniumLibrary Firefox profile
59de230 
The SeleniumLibrary default Firefox profile is now removed. When
Firefox created and if Firefox profile is not defined, then the
default Selenium FirefoxProfile is used.

Fixes robotframework#883
aaltat added a commit that referenced this issue Sep 6, 2017
@aaltat
Removes SeleniumLibrary Firefox profile (#885)
091e359 
* Removes SeleniumLibrary Firefox profile

The SeleniumLibrary default Firefox profile is now removed. When
Firefox created and if Firefox profile is not defined, then the
default Selenium FirefoxProfile is used.

Updated Open Browser keyword documentation when the FF profile has changed.
Adds namedtuple which contains selenium version

Fixes based on the comments

Fixes #883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaltat aaltat

Labels
backwards incompatible beta 3 enhancement priority: medium
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@pekkaklarck @aaltat