Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait Until Element Is Enabled should also check readonly status #958

Closed
pekkaklarck opened this issue Oct 18, 2017 · 0 comments
Closed

Wait Until Element Is Enabled should also check readonly status #958

pekkaklarck opened this issue Oct 18, 2017 · 0 comments

Comments

@pekkaklarck
Copy link
Member

Element Should (Not) Be Enabled validates that element is enabled and not read-only, but Wait Until Element Is Enabled only checks is the element enabled. For consistency reasons we should change the latter to also validate read-only status.

At the moment Element Should (Not) Be Enabled also checks is the element type is 'input', 'select', 'textarea', 'button' or 'option'. That's a bad idea because it ignores HTML5 input elements (see also #546). Instead of trying to make the list of valid input elements perfect, I think it's better to not do any type checking.

@pekkaklarck pekkaklarck added this to the v3.0.0 milestone Oct 18, 2017
pekkaklarck added a commit to pekkaklarck/SeleniumLibrary that referenced this issue Oct 18, 2017
"Element Should (Not) Be Enabled" and "Wait Until Element Is Enabled"
now all validate that the element is enabled and not readonly. Also
removed broken element type validation from the former keywords.

Fixes robotframework#958.
@aaltat aaltat closed this as completed in 4e48199 Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant