Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webdrivertools.py #1698

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Update webdrivertools.py #1698

merged 1 commit into from
Oct 10, 2022

Conversation

remontees
Copy link
Contributor

Support Edge webdriver for Linux.
@aaltat
Copy link
Contributor

aaltat commented Mar 9, 2021

This breaks one of the unit tests, please fix it.

@remontees
Copy link
Contributor Author

remontees commented Mar 9, 2021

This breaks one of the unit tests, please fix it.

For sure, because the test is already expecting the .exe file instead of the cross-platform executable:

executable_path = "MicrosoftWebDriver.exe"

@idxn
Copy link

idxn commented Mar 10, 2021

@remontees Why do we need to update the code? Can you just specify the executable_path argument in the Open browser keyword as an example below?

Open Browser http://example.com Edge executable_path=msedgedriver

@aaltat
Copy link
Contributor

aaltat commented Mar 10, 2021

Because then it by default will work with larger community.

@remontees
Copy link
Contributor Author

remontees commented Mar 10, 2021

Because then it by default will work with larger community.

@idxn
That's it: if you try to open an Edge web browser in your test in a Linux environment, you would expect it to work (or say that the LINUX webdriver has not been installed), not that the Windows executable is missing.
In the meantime, thks for the trick.

@emanlove
Copy link
Member

emanlove commented Oct 9, 2022

Rechecked pull request against updated unit/acceptance tests with passing results.

@emanlove emanlove merged commit 8afcf10 into robotframework:master Oct 10, 2022
@emanlove emanlove added acknowledge To be acknowledged in release notes and removed in progress labels Oct 10, 2022
@emanlove emanlove added this to the v6.1.0 milestone Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge To be acknowledged in release notes enhancement priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants