Fix _find_by_data_locator #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed off by one in _find_by_data_locator
|
On second thought it might be a good idea to also change the error raised in the try or the message given in the except. The error that gets caught by that catch is a ValueError about unpacking with string's split() method: But the error message from the except in _find_by_data_locator catches that ValueError and replaces it with something that's in this case more vague, and implies that the reason the ValueError is raised is because of the condition in the try, rather than an unrelated ValueError. I'm not sure what the ideal fix here would be though. |
emanlove
added
bug
in progress
priority: high
acknowledge
|
I have some unit tests to verify this change which I will submit in another PR. |
emanlove
added a commit
to emanlove/robotframework-seleniumlibrary
that referenced
this pull request
Nov 2, 2024
emanlove
added a commit
to emanlove/robotframework-seleniumlibrary
that referenced
this pull request
Nov 2, 2024
Added a couple unit tests to verify markus-leben's fix (robotframework#1924) for allowing colons within the value of the data locator.
emanlove
added a commit
that referenced
this pull request
Nov 2, 2024
Fix find by data locator #1924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off by one in _find_by_data_locator which causes opaque failure on data values which contain a colon.
Example html:
<div data-automation-id="foo:bar">This might be trouble</div>Example robot:
Scroll Element Into View data:automation-id:foo:barError message:
Provided selector (automation-id:foo:bar) is malformed. Correct format: name:value.I don't love the person putting colons in their automation ID, but we don't always get to choose the html we're testing.