No Fail For Capture Page Screenshot When No Browser Is Opened (Issue #816)

[olivierverville]

The keyword Capture Page Screenshot will no longer fail, and simply return with a message when no browser is opened.

[aaltat]

Please also write a test and use status checker [1] to verify message

[1] https://github.com/robotframework/statuschecker/blob/master/README.rst

[olivierverville]

Not sure how to setup a test for this. If I close the browser, it will break other tests since they rely on the global suite setup to open their browser. Two ideas:

1) Call Close All Browsers in my new test case's setup, call Capture Page Screenshot within the test case itself, and call the suite's setup keyword back in my test case's teardown

2) Simply add a Capture Page Screenshot step to the global teardown. (after the browser(s) have/has been closed)

Thoughts?

[aaltat]

The first option is best. If I recall correctly, there are other test that do the similar thing.

[olivierverville]

I've added an acceptance test, and according to Travis it passes, but the build fails. The log doesn't really help, I can't seem to find what crashes.

[pekkaklarck]

Comments and empty lines are unnecessary and somewhat against the style used elsewhere in this codebase. I'd also say it's clearer to just have

try:
    self.browser
except RuntimeErrror:
  # ...

than

try:
    b = self.browser
except RuntimeErrror:
  # ...

when the b variable isn't used for anything. Could also consider using try/except/else instead of returning from except.

It might actually also be a good idea to create new BrowserNotOpen exception and the browser property to use it instead of the generic RuntimeError. The code here would then look like

try:
    self.browser
except BrowserNotOpen:
  # ...

which would be really clean. Not sure is it worth it, though.

[olivierverville]

Good suggestions. I'll get back to this on Monday

[pekkaklarck]

The failure is most likely caused by the Status checker tool finding a problem when it does post-execution analysis. Do you get that failure also locally?

[olivierverville]

Here we go :)