Table cleanup #992
Merged
Table cleanup #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes enhancing error messages. Somewhat related to robotframework#925.
- Fix "Get Table Cell" and "Table Cell Should Contain" with mixed th/td. - Fix "Table Column Should Contain" with th when using negative indexes. Fixes robotframework#990.
Earlier most table tests were run both using table locator as the default strategy and as XPATH. This has several problems: - It made test system unnecessarily complex. - Running most tests twice increased execution time considerable. - It wasn't possible to use any other locator strategy. - Keyword names said tests would be run using CSS and XPATH locators but that wasn't true. This system was now removed. Tests were changed to use ID, CSS and XPATH strategies here and there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing docs, cleaning up code, fixing bugs, ... See commit messages of individual commits for details.