OS X #123
Closed
OS X #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I see it failed to build with Travis CI. Anything I can do about this? |
|
There's very clear errors in the log. |
|
Ah, TARGET_OS_MAC is confusing. (http://stackoverflow.com/questions/9948919/cant-seem-to-conditionally-compile-for-iphone-mac) |
…s always called in the case of duplicate updatedTransaction callbacks
The crash is random, but it is happening. So let's prevent it.
…atting and added new lines where necessary.
…s always called in the case of duplicate updatedTransaction callbacks
…atting and added new lines where necessary.
# Conflicts: # RMStore/RMStore.m
# Conflicts: # RMStore/RMStore.m
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why SKDownload doesn't have transaction property on OS X and how this effects RMStore. But these changes make it build and work when you don't need SKDownloads.