Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit changes upstream? #1

Closed
traversaro opened this issue Apr 22, 2015 · 7 comments
Closed

Submit changes upstream? #1

traversaro opened this issue Apr 22, 2015 · 7 comments

Comments

@traversaro
Copy link
Contributor

@francesco-romano I guess you are not planning to add cmake support for building other bindings, so I guess we can go on and submit our modification upstream (better rpath support and matlab bindings compiled in cmake) so we can drop this fork.

@francesco-romano
Copy link
Contributor

I was unsure about simulink bindings support. Right now I found them quite unnecessary (at least for us).

About the matlab binding: they should be tested on old cmake (do you remember the issue of @rlober ?)

@traversaro
Copy link
Contributor Author

I would simply drop the simulink binding compilation for the moment if we are not so sure, we can always submit it upstream later. The problem of @rlober was with CMake 2.8.11 ?

@francesco-romano
Copy link
Contributor

Yes if I remember correctly.
I changed the cmake file, but I'd never had the chance to test it again.

@francesco-romano
Copy link
Contributor

@traversaro
I finished updating the CMakeFiles.
I don't know if you want to submit the changes upstream.
I'd not delete this repository anyway (maybe we can update it as soon as they do the release).
I still have to clean up the compilation options, but this will be a long term task (as soon as I start work seriously on the lib)

@traversaro
Copy link
Contributor Author

I forgot this thing even existed, and it is actually super-important for us. : )
I'll need to open an issue somewhere more visibile.

@traversaro
Copy link
Contributor Author

cc @S-Dafarra @gabrielenava

@traversaro
Copy link
Contributor Author

As we dropped the use of qpOASES matlab bindings (see robotology/robotology-superbuild#613) the only changes that are interesting to submit upstream and to switch using the upstream once accepted are:

As this have been submitted, I think we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants