-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit changes upstream? #1
Comments
I was unsure about simulink bindings support. Right now I found them quite unnecessary (at least for us). About the matlab binding: they should be tested on old cmake (do you remember the issue of @rlober ?) |
I would simply drop the simulink binding compilation for the moment if we are not so sure, we can always submit it upstream later. The problem of @rlober was with CMake 2.8.11 ? |
Yes if I remember correctly. |
@traversaro |
I forgot this thing even existed, and it is actually super-important for us. : ) |
As we dropped the use of qpOASES matlab bindings (see robotology/robotology-superbuild#613) the only changes that are interesting to submit upstream and to switch using the upstream once accepted are:
As this have been submitted, I think we can close the issue. |
@francesco-romano I guess you are not planning to add cmake support for building other bindings, so I guess we can go on and submit our modification upstream (better rpath support and matlab bindings compiled in cmake) so we can drop this fork.
The text was updated successfully, but these errors were encountered: