Cleanup namespaces boost #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
reviewed
Jun 19, 2023
| @@ -8,6 +8,7 @@ | |||
| #include <chrono> | |||
|
|
|||
| using namespace std::literals::chrono_literals; | |||
| using namespace boost::asio::ip; | |||
There was a problem hiding this comment.
I tought the idea of the PR is to remove the using namespace, is this addition intentional?
There was a problem hiding this comment.
Ahh I got it, the idea was to remove it from the headers, make sense.
There was a problem hiding this comment.
I moved it in the cpp that should be harmless in theory, but in case I can get rid of it also from the cpp
traversaro
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanup the namespace usage of boost asio in some header