Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of model tutorials #613

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Cleanup of model tutorials #613

merged 3 commits into from
Mar 17, 2022

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Mar 16, 2022

First step toward #568 . In this PR no actual migration is done, but all the models have been cleanup to make sure that they work correctly, so that the PR with the migration will contain only migration-related changes.

In particular, this PR:

  • Updates all the sdf files to use version 1.7
  • Fix coupled_pendulum/conf/gazebo_controlboard.ini to make sure that the coupled_pendulum model actually works.
  • Fix authors that referred to outdated entities
  • Migrated ``cameraandmulticamera` example to use new `frameGrabber_nws_yarp` network wrapper server YARP device
  • Remove hardcoded plugin location in video_texture plugin
  • Remove unused .sdf files

@traversaro traversaro requested review from ste93 and Nicogene March 16, 2022 16:37
@traversaro
Copy link
Member Author

Please ignore the CI failure, it is a non-deterministic issue not related with this PR.

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traversaro traversaro merged commit ac0d4c2 into master Mar 17, 2022
@traversaro traversaro deleted the cleanupModelTutorials branch March 17, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants