Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading vector from configuration files with parenthesis #141

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Apr 4, 2024

Closes #138

As discussed in robotology/yarp#3092, it is recommended for future software that uses YARP to use vectors in configuration files by indicating them with parenthesis, i.e. to refer to them with:

nameOfList (elem1 elem2 elem3)

instead of:

nameOfList elem1 elem2 elem3

After this PR, now plugins support both the with-parentheses and without-parenthesis style, printing a warning if the without-parenthesis style is used.

@xela-95 xela-95 self-assigned this Apr 4, 2024
@xela-95 xela-95 linked an issue Apr 4, 2024 that may be closed by this pull request
@xela-95 xela-95 marked this pull request as ready for review April 4, 2024 15:57
@xela-95 xela-95 requested a review from traversaro April 4, 2024 15:57
@traversaro
Copy link
Member

If you can require gazebo-yarp-plugins 4.11.0, consider switching your configuration files to the vector with parenthesis style.

Copy and paste error?

@xela-95
Copy link
Member Author

xela-95 commented Apr 4, 2024

If you can require gazebo-yarp-plugins 4.11.0, consider switching your configuration files to the vector with parenthesis style.

Copy and paste error?

Of course 🤣

@xela-95
Copy link
Member Author

xela-95 commented Apr 5, 2024

Merging 🚀

@xela-95 xela-95 merged commit f08dd84 into main Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting loading vector from configuration files with parenthesis
2 participants