Remove useless checkNetwork calls in plugins that do not require the YARP network #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xela-95
force-pushed
the
fixnoyarpserver
branch
from
5aed9ff
to
ce5a910
Compare
xela-95
approved these changes
Aug 12, 2024
|
Rebased on main. Merging 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarp::os::Network::checkNetwork()check that the yarpserver (the name server related to YARP ports) is available. However, since in gazebo-yarp-plugins we decouple the regular plugin and the YARP network wrapper server, there is no strict requirement anymore for the yarpserver is up, a user could simply run some devices without any yarpserver.I noticed this as in my machine the
ConfigurationParsingTestwere segfaulting, until I fixed this. Hopefully this was also the reason why the tests were failing in the macOS CI.