Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test skip and options to tolerate non-deterministic failure #195

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Aug 20, 2024

We recently have a few PRs that solved non-deterministic failures:

Thanks to these fixes, we can reduce the number of workarounds, and only run multiple times tests that are known to be flaky.

@traversaro traversaro changed the title Remove test skip and option to tolerate non-deterministic failure Remove test skip and options to tolerate non-deterministic failure Aug 20, 2024
@traversaro
Copy link
Member Author

Ok, apparently CameraTest still segfaults on apt, while ConcurrentInstancesTest fails like:

ODE INTERNAL ERROR 1: assertion "!colliders_initialized" failed in dInitColliders() [collision_kernel.cpp:168]

that is due to gazebosim/gz-sim#18 .

@traversaro
Copy link
Member Author

Ok, the good news is that all test pass on macos now, so #54 is fixed. On conda we still have problems with LaserTest and CameraTest, while on apt with CameraTest and ControlBoardOnMultipleGazeboInstancesTest/ConcurrentInstancesTest.

@traversaro traversaro changed the title Remove test skip and options to tolerate non-deterministic failure Reduce test skip and options to tolerate non-deterministic failure Aug 20, 2024
@traversaro
Copy link
Member Author

Ok, now the CI passes, and in the tests we just skip/permit failure only for tests for which we have open issue tracking the problems.

@traversaro traversaro merged commit 1f5b43d into main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants