add test for Camera plugin #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 80.10% 85.32% +5.21%
==========================================
Files 11 14 +3
Lines 558 906 +348
==========================================
+ Hits 447 773 +326
- Misses 111 133 +22
☔ View full report in Codecov by Sentry. |
traversaro
reviewed
Aug 18, 2023
tests/camera/camera_nws.xml
Outdated
| <action phase="shutdown" level="5" type="detach" /> | ||
| </device> | ||
| </devices> | ||
| </robot> |
There was a problem hiding this comment.
Missing new line at the end of the file.
traversaro
reviewed
Aug 18, 2023
|
|
||
| set(_env_vars) | ||
| list(APPEND _env_vars "GZ_SIM_SYSTEM_PLUGIN_PATH=$<TARGET_FILE_DIR:GazeboYarpCamera>") | ||
| list(APPEND _env_vars "LIBGL_ALWAYS_SOFTWARE=1") |
There was a problem hiding this comment.
I saw that you added this in the Laser tests as well. However, this should only be necessary if you are using WSL2, not in general. Furthermore, it should not be necessary anymore after the release of gz-renderng 7.4.1 , see gazebosim/gz-sim#920 (comment) . However, I will open a separate issue for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36