-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python bindings installation and support building bindings as standalone projects #398
Conversation
…stalled in arbitrary directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this approval as an ack of these modifications, I'm not very familiar with cmake and bindings in general
Yes, I think for most ami-iit's repos reviews are mostly an ack, unless the maintainer wants to go into deep and comments. |
I initially just fixed the installation of
__init__.py
forwearables
and fixed compilation on Windows, to permit to merge robotology/robotology-superbuild#1717 (see 5e0ac8c, 72f02ae and 7b42767).However, while I was at it, I thought it was useful to also fix robotology/robotology-superbuild#1268, propagating what was done in robotology/idyntree#1209 (5ed3e38).
Then, as this was necessary to package easily hde on conda-forge, I also added support to compile the python bindings as a standalone project, linking against an existing external HDE installation (5b6d09f and 002b75d).
This PR change the internal ALIAS of
WearableData
andWearableActuators
target toWearableData::WearableData
andWearableActuators::WearableActuators
for consistency with the namespace used during the install. If you have been usingwearables
viaFetchContent
/add_subdirectory
, please change all your instances ofWearable::WearableData
toWearableData::WearableData
and of ofWearable::WearableActuators
toWearableActuators::WearableActuators
.