Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wrist Mk 2.1 project #56

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Added wrist Mk 2.1 project #56

merged 3 commits into from
Jul 28, 2023

Conversation

ale-git
Copy link
Contributor

@ale-git ale-git commented Jul 26, 2023

I've created the Simscape digital twin of the Mk 2.1 spherical wrist.
The wrist_decoupler subsystem used by the Simulink controller is used to automatically generate the code that is included in the EMS and AMC firmware projects, and it is now reconfigurable at runtime, i.e. it hasn't to be updated or regenerated when there is a change in the geometric structure of the wrist. The configurable parameters at runtime are:

  • arm angle offests
  • platform angle offsets
  • arm bending
  • right/left wrist

@ale-git ale-git added team-five Activity performed by Team FIVE domain-firmware Pertains to FW development domain-modeling Pertains to model-based design labels Jul 26, 2023
@ale-git ale-git self-assigned this Jul 26, 2023
@ale-git ale-git requested a review from pattacini as a code owner July 26, 2023 08:43
@pattacini pattacini linked an issue Jul 26, 2023 that may be closed by this pull request
@pattacini
Copy link
Member

Thanks heaps @ale-git 👍🏻
I'll have a look asap.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ale-git for this upgrade.

I've posted a few inline comments to address for the README.

Also, a couple of questions:

  1. Since this model subsumes mk2 (if I got it right), do you think that in the long run we could remove the old model, keeping it available just in the short period?
  2. Have you already planned to see if the current documentation deserves some amendments?

wrist_mk2_1/README.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that images and text are a verbatim copy of wrist mk2.

I'd suggest that we update the content of the README in order to point out the part on the configuration introduced by this PR.

@pattacini
Copy link
Member

Since this model subsumes mk2 (if I got it right), do you think that in the long run we could remove the old model, keeping it available just in the short period?

Just aligned F2F w/ @ale-git. The mechanics are different and could be handled easily within a unique model relying on variant subsystems.

Copy link
Contributor Author

@ale-git ale-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pattacini, I've updated the README.md with the new pictures and detail of the geometry configuration.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-firmware Pertains to FW development domain-modeling Pertains to model-based design team-five Activity performed by Team FIVE
Projects
None yet
2 participants