Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline how initial config is set for boards, remove duplicated code replacement folders #89

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

mfussi66
Copy link
Member

@mfussi66 mfussi66 commented Mar 15, 2024

This PR applies to the following:

  • Common
  • AMCFOC
  • AMCBLDC_Experimental

It introduces a function called update_actuators_config, stored in Common, that can be used to update the initial configuration of the motion controller (motor config, limits, pids...), and store it in the related dictionary.

The board-specific projects can use it with the following, for example:

update_actuators_config("amcbldc.sldd", "AmcbldcInitConf", amcbldc_init_config())

The first argument is the target dictionary, the second argument is the desired name of the struct containing the configuration (it MUST match the name in the Simulink model), and the third is a script containing the parameters.

amcbldc_init_config and amcfoc_init_config are function scripts that contain the respective init parameters, and are placed in the respective projects.

@mfussi66 mfussi66 self-assigned this Mar 15, 2024
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spotted that rtw_mutex has been removed.
Any comment on this?

@mfussi66
Copy link
Member Author

It's in the project Common. Should it be placed on a specific board project?

@pattacini
Copy link
Member

Ok, but it was already in common? Asking because this PR doesn't provide rtw_mutex in common right away.

So, are you just cleaning up the specific board projects?

If my understanding is correct, that's perfectly fine 👍🏻

@mfussi66
Copy link
Member Author

Yes my bad, I did not specify. The directories were duplicated everywhere, and so was the code replacement with rtw_mutex! They were already in Common, that's why it did not show up on the PR.

@mfussi66 mfussi66 changed the title Streamline the way initial configuration is set for boards Streamline how initial config is set for boards, remove duplicated code replacement folders Mar 15, 2024
@pattacini pattacini merged commit 168ded6 into robotology:devel Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants