Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AMBLDC project with AMCBLDC experimental #94

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

mfussi66
Copy link
Member

@mfussi66 mfussi66 commented Aug 30, 2024

This PR aims to replace the current AMCBLDC architectural model with the one present in AMCLBDC_experimental.

The experimental project depends on the common project, to reference Simulink models that could be shared between other boards (such as the amc-foc).

The simulink models in common are:

In the amcbldc project the current specialized models are kept:

  • can encoder
  • can decoder
  • supervisor-tx

This PR is the result of the tests performed in #92.

Important

The ARM Cortex M CMSIS functions are disabled.

@mfussi66 mfussi66 self-assigned this Aug 30, 2024
@mfussi66 mfussi66 marked this pull request as ready for review August 30, 2024 12:01
@pattacini pattacini linked an issue Aug 30, 2024 that may be closed by this pull request
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't remove the old project. Instead, call it amcbldc-old. I'll get rid of it later.
Also, we need to run a test campaign on the whole wrist before merging, unless this was already done. My understanding of #92 is that you ran tests on a single board. Correct me if I'm wrong.

@mfussi66
Copy link
Member Author

True that, I'll do both and keep this in draft until the tests on the wrist are done.

@pattacini pattacini marked this pull request as draft August 30, 2024 14:06
@pattacini pattacini marked this pull request as ready for review September 5, 2024 12:16
@pattacini
Copy link
Member

pattacini commented Sep 5, 2024

Testing on the robot completed successfully ✅

@pattacini pattacini merged commit 40b0275 into robotology:devel Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run a test campaign before merging AMCBLDC_experimental and AMCBLDC
2 participants