Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMCx mbd: codegen R2024a from icub-fw-models c8834b2 #523

Merged
merged 15 commits into from
Oct 11, 2024

Conversation

mfussi66
Copy link
Member

@mfussi66 mfussi66 commented Oct 8, 2024

@marcoaccame
Copy link
Contributor

I updated the minor versions of amc2c and amcbldc, and reset the revision to zero.

OK, as the minor number changes when we have the new binaries we shall need to update also the xml files in robots-configuration.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfussi66, it seems fine. I assume you have done the required test, correct?

If so, we can merge.

@mfussi66
Copy link
Member Author

mfussi66 commented Oct 8, 2024

Hi @mfussi66, it seems fine. I assume you have done the required test, correct?

If so, we can merge.

The tests are linked in the PR body, both performed on single motors and on the robot.

@mfussi66
Copy link
Member Author

mfussi66 commented Oct 8, 2024

I updated the minor versions of amc2c and amcbldc, and reset the revision to zero.

OK, as the minor number changes when we have the new binaries we shall need to update also the xml files in robots-configuration.

I increased the amc2c version from 3.0.4 to 3.2. That was a mistake since the amc2c is independent from the left or right decoupler. I'll change it to 3.1.

@mfussi66
Copy link
Member Author

mfussi66 commented Oct 9, 2024

I updated the minor versions of amc2c and amcbldc, and reset the revision to zero.

OK, as the minor number changes when we have the new binaries we shall need to update also the xml files in robots-configuration.

I increased the amc2c version from 3.0.4 to 3.2. That was a mistake since the amc2c is independent from the left or right decoupler. I'll change it to 3.1.

Fixed this @marcoaccame . If that's ok to you we can merge.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@marcoaccame marcoaccame merged commit 82d1d4e into robotology:devel Oct 11, 2024
simeonedussoni pushed a commit to simeonedussoni/icub-firmware that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants