-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMCx mbd: codegen R2024a from icub-fw-models c8834b2 #523
Conversation
OK, as the minor number changes when we have the new binaries we shall need to update also the xml files in robots-configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mfussi66, it seems fine. I assume you have done the required test, correct?
If so, we can merge.
The tests are linked in the PR body, both performed on single motors and on the robot. |
I increased the amc2c version from 3.0.4 to 3.2. That was a mistake since the amc2c is independent from the left or right decoupler. I'll change it to 3.1. |
Fixed this @marcoaccame . If that's ok to you we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks
This PR updates the MBD code for the AMCBLDC and AMC boards up to the commit: robotology/icub-firmware-models@c8834b2
Highlights of this release are in the following PRs:
Integration tests on a single setup and on the robot are performed in
I updated the minor versions of amc2c and amcbldc, and reset the revision to zero.