Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused iCub3 hand configuration files #209

Closed
wants to merge 4 commits into from
Closed

Remove unused iCub3 hand configuration files #209

wants to merge 4 commits into from

Conversation

traversaro
Copy link
Member

@traversaro
Copy link
Member Author

Apparently the script requires some modification to properly deal with "removal" of generated files.

@traversaro
Remove automatically generated files in CI start
2f8b9cf 
This ensure that they are removed if they are not generated anymore
@traversaro
Update ci.yml
f1ad249
@traversaro
Update ci.yml
f80ba82
@Nicogene
Copy link
Member

I missed this PR sorry! Is it ready to be merged @traversaro ?

Nicogene
Nicogene approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traversaro
Copy link
Member Author

I do not remember well to be honest.

@traversaro
Copy link
Member Author

traversaro commented Nov 7, 2021 •
edited
Loading

I checked now the PR and it seems to me ready to be merged, the files that I Wanted to remove to avoid confusion were modified in #212, however it seems to me that it still make sense to just remove them, what do you think @Nicogene ?

@Nicogene
Copy link
Member

I checked now the PR and it seems to me ready to be merged, the files that I Wanted to remove to avoid confusion were modified in #212, however it seems to me that it still make sense to just remove them, what do you think @Nicogene ?

Yes go ahead

@traversaro
Copy link
Member Author

I do not have the time to fix the conflict at this time. Let's close and reopen in the future.

@traversaro traversaro closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused hand-related configuration files in icub-models/iCub/conf_icub3 directory
2 participants
@traversaro @Nicogene