Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velocityControlImplementationType missing parameter for iCubGazeboV3 #106

Closed
GiulioRomualdi opened this issue Sep 23, 2021 · 11 comments
Closed

Comments

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Sep 23, 2021

This parameter is required after the gazebo yarp plugin v4.0.0 release

@mebbaid
Copy link
Contributor

mebbaid commented Nov 11, 2021

any updates on this issue ?

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Nov 11, 2021

This should fix by robotology/icub-models-generator#212

Could you try with the devel branch?

@mebbaid
Copy link
Contributor

mebbaid commented Nov 11, 2021

@traversaro this maybe the issue that the Jonathan from Australia was having (he mentioned this during the ergocub update meeting). Couldn't tag him because i didn't find him on this site.

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Nov 11, 2021

Fixed by 6239efe

@lrapetti
Copy link
Member

@traversaro this maybe the issue that the Jonathan from Australia was having (he mentioned this during the ergocub update meeting). Couldn't tag him because i didn't find him on this site.

@Woolfrey

@traversaro
Copy link
Member

Thanks a lot @mebbaid, I think indeed that it is! 6239efe (and the related PR robotology/icub-models-generator#212) fixed it in devel, but probably @Woolfrey downloaded either master or released version of icub-models. Let's release a new version of icub-models so users can get a working iCub3 models without a lot of hassle.

@traversaro
Copy link
Member

Hopefully we can do a 1.22 release (see #109) to avoid confusion in all users.

@traversaro
Copy link
Member

Hopefully we can do a 1.22 release (see #109) to avoid confusion in all users.

Done: https://github.com/robotology/icub-models/releases/tag/v1.22.0 .

@traversaro
Copy link
Member

Hopefully we can do a 1.22 release (see #109) to avoid confusion in all users.

Done: https://github.com/robotology/icub-models/releases/tag/v1.22.0 .

I also updated the LatestReleases file in the robotology-superbuild: robotology/robotology-superbuild#920 . So the next conda package generation will get the updated icub-models, let me know if there is anything else that we could do to make sure that this issue is fixed without the need for the user to manually switch branches or do stuff like that. @mebbaid @Woolfrey

@mebbaid
Copy link
Contributor

mebbaid commented Nov 12, 2021

@traversaro it seems that this fixes the issue and the iCubGazeboV3 starts correctly.

@Woolfrey
Copy link

I saw this; thanks!

Github notifications are being sent to my gmail instead of my iit email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants