Add cli11 dependency #1684
Merged
Add cli11 dependency #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xela-95
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Thank @traversaro! Just a minor non blocking-comment.
LGTM!
| @@ -79,6 +79,7 @@ ace = "*" | |||
| asio = "*" | |||
| assimp = "*" | |||
| boost = "*" | |||
| cli11 = "*" | |||
There was a problem hiding this comment.
Shouldn't this be placed under the "ROBOTOLOGY_USES_GZ" dependencies for clarity?
There was a problem hiding this comment.
Good point. To be honest, as it is quite a small library, I prefer to keep it in the group of generic dependencies, so that if other libraries start depend on it I do not need to remember to move it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is quite small, and will be required by robotology/gz-sim-yarp-plugins#179 . For conda/pixi I just add it as any required dependency (and anyhow it is already installed as gz-sim transitive dependency) while for apt I documented its installation where we explain how to install gz-sim as
libcli-devis not available in Ubuntu 20.04 (#1439). Once we drop the Ubuntu 20.04 installation, we can just add it to theapt.txtfile.