Fix definition of BLOCKFACTORY_PLUGIN_PATH on Windows #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
Nicogene,
diegoferigo and
nunoguedelha
and removed request for
Nicogene
diegoferigo
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, BlockFactory and WBToolbox install their BlockFactory plugins in
<prefix>/bin/blockfactory, so it is this directory that needs to be added inBLOCKFACTORY_PLUGIN_PATHinstead of<prefix>/lib/blockfactoryas done on Linux and macOS .See https://github.com/robotology/blockfactory/blob/fe2c6369f73a3cf0a300297989e7c6c536df198f/cmake/BlockFactoryPlugin.cmake#L96 for where the logic of where to install the BlockFactory plugins is defined.