Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming of ergoCub leg imus #513

Merged
merged 2 commits into from
May 16, 2023

Conversation

isorrentino
Copy link
Contributor

As per the title. In addition, I aligned the name of the port to expose the right arm ft and the feet imu.

@traversaro
Copy link
Member

Hi @isorrentino, probably we need to align this with #505 and ideally icub-tech-iit/documentation#271 if we agree on this. If you are in IIT we can quickly align on this, I can come down to the ergoCub to discuss. fyi @GiulioRomualdi

@isorrentino
Copy link
Contributor Author

Hi @traversaro sure, I'm here.

@pattacini pattacini marked this pull request as draft May 15, 2023 14:17
@pattacini
Copy link
Member

Hi @isorrentino, probably we need to align this with #505 and ideally icub-tech-iit/documentation#271 if we agree on this. If you are in IIT we can quickly align on this, I can come down to the ergoCub to discuss. fyi @GiulioRomualdi

Converted to draft for the time being.

@isorrentino
Copy link
Contributor Author

isorrentino commented May 16, 2023

Today I rebased branch branch on devel (updated yesterday night) and the robot does not start. The error is:

[ERROR] ParametricCalibratorEth:  Torso_Calibrator : number of joints of device to calibrate ( 2 ) does not match the number of joints in calibrator config file ( 3 )
[INFO] Left_Leg_Calibrator : starting calibration
[DEBUG] torso-calibrator finished calibration of device torso-mc_remapper

I'm debugging with @AntonioConsilvio and we found that this commit 62c5dd0 is the cause.

cc @traversaro @pattacini @S-Dafarra @DanielePucci

@pattacini
Copy link
Member

@traversaro, the CI didn't catch it because I have to disable the calibrator during it.

@isorrentino
Copy link
Contributor Author

Since this PR is in draft, for the time being, I pushed the modification here to have the robot working (68e8520d26716fb4c2220dc32269391cbfb4fb03).

@pattacini
Copy link
Member

Today I rebased branch branch on devel (updated yesterday night) and the robot does not start. The error is:

[ERROR] ParametricCalibratorEth:  Torso_Calibrator : number of joints of device to calibrate ( 2 ) does not match the number of joints in calibrator config file ( 3 )
[INFO] Left_Leg_Calibrator : starting calibration
[DEBUG] torso-calibrator finished calibration of device torso-mc_remapper

I'm debugging with @AntonioConsilvio and we found that this commit 62c5dd0 is the cause.

cc @traversaro @pattacini @S-Dafarra @DanielePucci

Should be fixed via #515.

@isorrentino
Copy link
Contributor Author

Should be fixed via #515.

Perfect, then. I can rebase this PR ontop.

@isorrentino
Copy link
Contributor Author

I tested this branch rebase on this pr #515 and everything works fine.

Yesterday, @traversaro @GiulioRomualdi and I discussed this comment #513 (comment), and we agreed that this PR is not touching files changed here #505. So if you (@pattacini and @traversaro ) agree we could go on with this PR.

@pattacini
Copy link
Member

So if you (@pattacini and @traversaro ) agree we could go on with this PR.

Oki 👍🏻

I tested this branch rebase on this pr #515 and everything works fine.

Put in ready for review then.

@pattacini pattacini marked this pull request as ready for review May 16, 2023 13:43
@pattacini pattacini merged commit 4d8a1cc into robotology:devel May 16, 2023
@isorrentino isorrentino deleted the isorrentino/addIMULegs branch May 16, 2023 21:35
mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this pull request Jun 19, 2023
Co-authored-by: icub <icub@iit.it>
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Co-authored-by: icub <icub@iit.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants