-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming of ergoCub leg imus #513
Conversation
Hi @isorrentino, probably we need to align this with #505 and ideally icub-tech-iit/documentation#271 if we agree on this. If you are in IIT we can quickly align on this, I can come down to the ergoCub to discuss. fyi @GiulioRomualdi |
Hi @traversaro sure, I'm here. |
Converted to draft for the time being. |
Today I rebased branch branch on
I'm debugging with @AntonioConsilvio and we found that this commit 62c5dd0 is the cause. |
@traversaro, the CI didn't catch it because I have to disable the calibrator during it. |
352272c
to
68e8520
Compare
Since this PR is in draft, for the time being, I pushed the modification here to have the robot working (68e8520d26716fb4c2220dc32269391cbfb4fb03). |
Should be fixed via #515. |
Perfect, then. I can rebase this PR ontop. |
68e8520
to
3b11e8c
Compare
I tested this branch rebase on this pr #515 and everything works fine. Yesterday, @traversaro @GiulioRomualdi and I discussed this comment #513 (comment), and we agreed that this PR is not touching files changed here #505. So if you (@pattacini and @traversaro ) agree we could go on with this PR. |
Oki 👍🏻
Put in ready for review then. |
Co-authored-by: icub <icub@iit.it>
Co-authored-by: icub <icub@iit.it>
As per the title. In addition, I aligned the name of the port to expose the right arm ft and the feet imu.