Do not overwrite default linker flags so that LDFLAGS environment variable is considered #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable is considered
traversaro
requested review from
diegoferigo,
lrapetti and
yeshasvitirupachuri
as code owners
|
FYI @Yeshasvitvs @lrapetti |
diegoferigo
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Tweaking the linker flags is a legacy that originated here in wearables few years ago and I personally spread all over the projects I either developed or maintained. Thanks for taking care of all the repositories that were affected, I'm going to accept all the PRs without commenting all of them 😉
I leave handling the releasing process to the current developers.
yeshasvitirupachuri
approved these changes
Apr 12, 2021
lrapetti
approved these changes
Apr 12, 2021
@traversaro Done https://github.com/robotology/wearables/releases/tag/v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one wants to specify additional linked flags, those should be appended to
CMAKE_SHARED_LINKER_FLAGS, not overwrite it as this would lead to theLDFLAGSenvironment variable to be ignored, leading to linking errors in some environments (for example conda).For more details see:
It would be convenient to tag a released after this fix is integrated to fix the conda binary generation at the robotology-superbuild level (see robotology/robotology-superbuild#681). Let me know if you want to do that or you like me to do it.
Fix robotology/robotology-superbuild#681 .