Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toml package usage #133

Closed
auscompgeek opened this issue Dec 28, 2021 · 9 comments
Closed

Replace toml package usage #133

auscompgeek opened this issue Dec 28, 2021 · 9 comments
Labels
good first issue Good for newcomers

Comments

@auscompgeek
Copy link
Member

The toml package is unfortunately unmaintained, and implements TOML v0.5.0. The rest of the ecosystem has moved to support TOML v1.0.0.

There are a few TOML v1.0.0 libraries we could use, including:

@auscompgeek auscompgeek added the good first issue Good for newcomers label Dec 28, 2021
@JawadHalabiMTB
Copy link
Contributor

Hi @auscompgeek where exactly you use that package ?

@auscompgeek
Copy link
Member Author

@JawadHalabiMTB If you search the code for toml. you should find all usages of it. It's used in several places.

@TheTripleV
Copy link
Member

There seems to be a push to get tomli included in stdlib. hukkin/tomli#141

@virtuald
Copy link
Member

tomli seems like a good choice

@JawadHalabiMTB
Copy link
Contributor

@auscompgeek 10x man so we can just add tomli package to setup.cfg under [options]->install_requires i guess

@auscompgeek
Copy link
Member Author

Well, the code would also have to be updated to use tomli, but yes that'd be the first step.

@JawadHalabiMTB
Copy link
Contributor

Sure that's my thought as well i mean for sure it should be installed via pip and then just replace all the "import toml" with "import tomli" as wel as the usage and still don't break functionality Ex: toml.load(). I am on it

JawadHalabiMTB added a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 3, 2022
JawadHalabiMTB added a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 3, 2022
JawadHalabiMTB added a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 3, 2022
@JawadHalabiMTB
Copy link
Contributor

Please note that tomli ntends to be minimal so it has no dump/s function which is required by the project so i think we should rethink about the tomli solution

JawadHalabiMTB added a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 3, 2022
JawadHalabiMTB added a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 3, 2022
virtuald pushed a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 8, 2022
virtuald pushed a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 8, 2022
virtuald pushed a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 8, 2022
virtuald pushed a commit to JawadHalabiMTB/robotpy-build that referenced this issue Jan 8, 2022
virtuald added a commit that referenced this issue Jan 8, 2022
Patch 1 solution for "Replace toml package usage #133"
@auscompgeek
Copy link
Member Author

Done in #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants