-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow create / update users on the API users table with autenticated token #45
Feature: allow create / update users on the API users table with autenticated token #45
Conversation
Hi @robsontenorio ! Any special reason to not accept this PR? It is out of scope or something missing? Pls let me know! Thx in advance! |
Alo @robsontenorio ! Tudo bem? Alguma razao específica pra nao querer aceitar o PR? Ou só correria mesmo? :) |
@frital hi there. Could you please include tests? I am not sure about the flow. With tests we could review it. |
I'd like to have this merged as well. Can I create the tests for you so you can merge the request? |
Hi @OfficialBAMM ! This would be nice!! Thx in advance! |
@OfficialBAMM for sure! We need tests to keep consistence through all features :) |
Created the PR. Let me know what you think! |
@OfficialBAMM I think you forgot to open PR |
@robsontenorio I opened an PR to this PR. See: frital#1 Atleast I think that how this should be done, but I might be wrong. |
implement test for robsontenorio#45
Thx @OfficialBAMM !! I just merged you PR!! I hope that now @robsontenorio will be able to accept the PR. =) |
I was already about to implement an egalitarian solution. Congratulations for the initiative. I need this feature. |
Could you guys test master branch with this feature DISABLED if everything is ok, before I release a tag ? |
Just tested it on my application with an empty string or removed at all. Both worked for me. Given a random string gives a Looking at the code, I see no reason why it shouldn't work for existing installations. |
This PR aims to, as an option, allow the API to create / update the authenticated user in the local users table.
To achieve this, its possible to inform a custom method on a custom UserProvider, that will be called instead
retrieveByCredentials
and will receive the complete decoded token as parameter, not just the credentials.