-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to update all #77
Conversation
- Prepare to update everything
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
Coverage ? 100.00%
Complexity ? 32
==========================================
Files ? 4
Lines ? 87
Branches ? 0
==========================================
Hits ? 87
Misses ? 0
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Haha I can understand that ;) you can close my PR when you want. Nice that you kept the phpcsfixer! |
@Nizari I have solved many gotchas after updating versions by looking up your MR |
Wow, Just seeing this now. Why did you incorporate the PRs as own changes? This removes the opensource idea of contributing to a project. If people take the changes for themselves. There is no excuse. Make an integration branch merge all the PRs.. Then change what you want. This way all are still credited for actually helping the project. |
Also never commit everything with "WIP".. say what you are doing as it explains the code changes i.e. took this from so and so PR. Doing this because of this PR.. etc. Conventional commits explains this better. Also if WIP why commit and push so much? Just push when the WIP is done? Locally can reset head etc. |
All in all I am disappointed I actually cared/took the time to give a PR to this project. |
Resolves #75 #70 #66 #67 #63 #64
leeway
option to prevent token excepetion due to network issuesapi_token
to get an alternative tokenignore_resources_validation
to ignore resource validationInspired by #75 . Big thansks to @Nizari effort !
Just opted to not include all boilerplate from #75 in order to keep things simple. After this MR I am able to review anothers MRs.