Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithm CPU percentil in documentation correct? #297

Closed
mgfnv9 opened this issue Jun 20, 2024 · 1 comment · Fixed by #298
Closed

Algorithm CPU percentil in documentation correct? #297

mgfnv9 opened this issue Jun 20, 2024 · 1 comment · Fixed by #298

Comments

@mgfnv9
Copy link

mgfnv9 commented Jun 20, 2024 •
edited
Loading

This is not bug.

In site https://github.com/robusta-dev/krr?tab=readme-ov-file#algorithm you type

For CPU, we set a request at the 99th percentile,

but then I running krr by default I see 95 percentil

CPU request: 95.0% percentile, limit: unset Memory request: max + 15.0%, limit: max + 15.0%

I don't understand CPU 95 or CPU 99 percentil correct for use?

krr:1.10.0
@aantn
Copy link
Contributor

aantn commented Jun 20, 2024

It is a bug in the docs!

95th percentile is correct on the latest version.

@aantn aantn mentioned this issue Jun 20, 2024
Merged
pavangudiwada pushed a commit that referenced this issue Jun 20, 2024
@aantn
Correct percentile numbers in README (#298)
99ce16c 
Fixes #297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct percentile numbers in README robusta-dev/krr
2 participants
@aantn @mgfnv9