Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load kubeconfig first in case it is provided by CLI arg #251

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Load kubeconfig first in case it is provided by CLI arg #251

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b540bf
Load kubeconfig first in case it is provided by CLI arg
shlomosfez Mar 29, 2024
c1c9d66
simplify implementation
shlomosfez Mar 31, 2024
f25364b
Merge branch 'main' into patch-1
shlomosfez Mar 31, 2024
b6e3b1e
Merge branch 'main' into patch-1
LeaveMyYard Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions robusta_krr/core/models/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,10 @@ def logging_console(self) -> Console:

def load_kubeconfig(self) -> None:
try:
config.load_incluster_config()
except ConfigException:
config.load_kube_config(config_file=self.kubeconfig, context=self.context)
self.inside_cluster = False
else:
except ConfigException:
config.load_incluster_config()
self.inside_cluster = True

def get_kube_client(self, context: Optional[str] = None):
Expand Down