Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate gitignore #6355

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Consolidate gitignore #6355

merged 3 commits into from
Jan 12, 2024

Conversation

B-Teague
Copy link
Contributor

@B-Teague B-Teague commented Jan 5, 2024

Consolidate all gitignore files to a single file at project root.

FYI, this will also ignore shell scripts that do not have file extensions, but I did not see any in this project. Please double check behind me that this is not ignoring more files than it should.

Closes #6354

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 6, 2024

Let's hold merging until we've discussed this on zulip.

Anton-4
Anton-4 previously approved these changes Jan 6, 2024
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @B-Teague, I've thought about ignoring binary files before but I was under the impression it was not possible, nice solution!

@B-Teague B-Teague force-pushed the merge-gitignore branch 2 times, most recently from b7c730e to 06f540e Compare January 6, 2024 19:20
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 9, 2024

I have not forgotten about this PR, I'll hopefully be able to review it tomorrow.

Anton-4
Anton-4 previously approved these changes Jan 10, 2024
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @B-Teague!

Anton-4
Anton-4 previously approved these changes Jan 10, 2024
B-Teague and others added 3 commits January 10, 2024 22:16
Keep certain files with no file extension

Keep specific files with no file extension

Delete all gitignore files
auto-merge was automatically disabled January 11, 2024 03:19

Head branch was pushed to by a user without write access

@B-Teague
Copy link
Contributor Author

@Anton-4 Sorry, I had to setup a GPG key to verify my commits. Please review at your convenience.

@Anton-4 Anton-4 merged commit 79ed84f into roc-lang:main Jan 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up gitignore files to have one at root of project
2 participants