Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate @rocicorp/reflect and @rocicorp/reflect-server from npm into replidraw-do #46

Merged
merged 7 commits into from
Apr 9, 2022

Conversation

grgbkr
Copy link
Contributor

@grgbkr grgbkr commented Apr 7, 2022

  1. Update to the new Reflect API that is independent from the Replicache API.
  2. Under the hood this is using the head of Replicache, so we are updating from 9.0.0-beta.0 to 10.0.0-alpaha.2.
  3. Since Reflect does not expose an onSync callback (since it is constantly streaming), updates initShape to use a mutator that is a no-op on the client and does the init only once on the server.

@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/replidraw-do/7SeWkaWcL6SEDSAxFyqewXSirp2U
✅ Preview: https://replidraw-do-git-grgbkr-reflect-client-rocicorp.vercel.app

@grgbkr grgbkr changed the title draft: integrate ReflectClient into replidraw-do refactor: integrate reflect and reflect-server from npm into replidraw-do Apr 9, 2022
@grgbkr grgbkr changed the title refactor: integrate reflect and reflect-server from npm into replidraw-do refactor: integrate @rocicorp/reflect and @rocicorp/reflect-server from npm into replidraw-do Apr 9, 2022
@grgbkr grgbkr merged commit 852f5f7 into main Apr 9, 2022
@grgbkr grgbkr deleted the grgbkr/reflect-client branch April 9, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant